Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feat: Update Babylon Testnet #179

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gbarkhatov
Copy link

Updates Babylon Phase-2 Testnet 5 data

exponent: 6
}],
base: 'ubbn',
name: 'Babylon Phase-2 Testnet',
Copy link

@jrwbabylonlab jrwbabylonlab Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Babylon Testnet? The registry is for babylon chain which was not involved in the phase-1 testnet

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

denom: 'ubbn',
exponent: 0
}, {
denom: 'bbn',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is for the 1000000 ubbn which is 1 BABY, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as it was + per keplr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keplr only have ubbn. but here i think it's asking for the unit to display if u have 1000000 ubbn. in our case is BABY.
So i think u should change this to baby instead
https://github.com/chainapsis/keplr-chain-registry/blob/main/cosmos/bbn-test.json#L26

}],
base: 'ubbn',
name: 'Babylon Phase-2 Testnet',
display: 'bbn',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I’m getting a bit confused with the terms bbn and BABY.

Shouldn’t the display also be set to BABY? I don’t think we use bbn anywhere except for the address prefix.

For what it’s worth, I have to admit that this ubbn, bbn, and BABY combination is extremely confusing! Let’s try to align and simplify this wherever possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved, let's change this to BABY

},
codebase: {

git_repo: 'https://github.com/babylonlabs-io/babylon/releases',
recommended_version: 'v0.18.2',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/babylonlabs-io/babylon/releases/tag/v1.0.0-rc.3
testnet is running with release candidates i believe. We shall add a reminder to update this once a formal release is cut

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we add this reminder? Right in the code as a comment?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to create an issue on our wallet component side to remind ourself later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants