Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary in writeFile #2856

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

hoangdv2429
Copy link
Contributor

@hoangdv2429 hoangdv2429 commented Dec 14, 2023

Description

Closes: #2834
This PR will remove unnecessary code as described in the issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainoe
Copy link
Contributor

sainoe commented Dec 19, 2023

It makes the E2E tests fail because writeFile doesn't have the required permissions anymore.

stdout: , stderr: Error: open /home/nonroot/.gaia/config/xxx.json: permission denied

@sainoe sainoe self-requested a review December 19, 2023 09:23
@hoangdv2429
Copy link
Contributor Author

@sainoe I will check on what's the right option to give in instead of 0o600

@hoangdv2429
Copy link
Contributor Author

@sainoe can you trigger the test again sir ?

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hoangdv2429.

@mpoke mpoke merged commit 779938c into cosmos:main Dec 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/e2e: writeFile unnecessrily leaks a file yet os.WriteFile already handles its functionality
4 participants