Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary in writeFile #2856

Merged
merged 3 commits into from
Dec 22, 2023
Merged

refactor: remove unnecessary in writeFile #2856

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71eab0a
remove unnecessary
hoangdv2429 Dec 14, 2023
b0b1aec
Merge branch 'main' into fix/writeFile_redundant
hoangdv2429 Dec 19, 2023
7f88b26
update
hoangdv2429 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tests/e2e/io.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ func copyFile(src, dst string) (int64, error) { //nolint:unparam
}

// writeFile write a byte slice into a file path
// create the file if it doesn't exist
// NOTE: this file can be write and read by everyone
func writeFile(path string, body []byte) error {
_, err := os.Create(path)
if err != nil {
return err
}

return os.WriteFile(path, body, 0o600)
return os.WriteFile(path, body, 0o666) //nolint:gosec
}
Loading