Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #896 so it works for ROS2 Iron. #898

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fixed #896 so it works for ROS2 Iron. #898

merged 1 commit into from
Feb 15, 2024

Conversation

ralphieraccoon
Copy link
Contributor

@ralphieraccoon ralphieraccoon commented Feb 15, 2024 •
edited
Loading

Description
Quick bugfix for #896, which doesn't work for iron or rolling because they use a ros2_control hardware interface version >3.15. For some reason still fails for rolling.

Affected Packages
List of affected packages:

  • webots_ros2_control

@ralphieraccoon ralphieraccoon changed the title Fixed #896 so it works for all ROS2 distros. Fixed #896 so it works for all ROS2 Iron. Feb 15, 2024
@ralphieraccoon ralphieraccoon changed the title Fixed #896 so it works for all ROS2 Iron. Fixed #896 so it works for ROS2 Iron. Feb 15, 2024
@omichel omichel self-requested a review February 15, 2024 15:35
omichel
omichel approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@omichel omichel merged commit 929c45c into cyberbotics:master Feb 15, 2024
5 of 7 checks passed
@ralphieraccoon ralphieraccoon deleted the hotfix_for_#896_iron_and_rolling branch February 15, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphieraccoon @omichel