[components] project_name -> code_location_name in scaffolded pyproject.toml #27480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
changed the base branch from
sean/components/code-location-scaffold-workspace
to
graphite-base/27480
smackesey
force-pushed
the
graphite-base/27480
branch
from
42436ff to
94e2d67
Compare
smackesey
force-pushed
the
sean/components/fix-code-location-name-pyproject-toml
branch
from
cc1a95e to
59253a3
Compare
smackesey
force-pushed
the
sean/components/fix-code-location-name-pyproject-toml
branch
from
59253a3 to
47f927a
Compare
smackesey
force-pushed
the
sean/components/fix-code-location-name-pyproject-toml
branch
from
47f927a to
2f17209
Compare
schrockn
approved these changes
Feb 2, 2025
smackesey
deleted the
sean/components/fix-code-location-name-pyproject-toml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The
tool.dagstersection in our scaffoldedpyproject.tomlcontained aproject_namefield. However, this isn't actually read by our tooling. What is read is acode_location_namefield. This renames theproject_namefield tocode_location_name. It affects bothdagsteranddagster-dg(which had started by copying thepyproject.tomlscaffolding from dagster core).How I Tested These Changes
Tweaked unit tests.