[components] Better error message for failing entry points (BUILD-647) #27530
+112
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
changed the title
smackesey
changed the base branch from
sean/components/windows/missing-component-error-message
to
graphite-base/27530
smackesey
force-pushed
the
windows/components/entry-point-error
branch
from
0fbef2d to
95bbc0b
Compare
smackesey
force-pushed
the
graphite-base/27530
branch
from
d91a48c to
8562f12
Compare
smackesey
changed the base branch from
graphite-base/27530
to
sean/components/component-type-list-json
This was referenced Feb 10, 2025
smackesey
force-pushed
the
sean/components/component-type-list-json
branch
from
8562f12 to
e8529a0
Compare
smackesey
force-pushed
the
windows/components/entry-point-error
branch
from
95bbc0b to
a003820
Compare
smackesey
changed the base branch from
sean/components/component-type-list-json
to
graphite-base/27530
smackesey
force-pushed
the
graphite-base/27530
branch
from
e8529a0 to
ab9603f
Compare
smackesey
force-pushed
the
windows/components/entry-point-error
branch
from
a003820 to
588c249
Compare
smackesey
force-pushed
the
graphite-base/27530
branch
from
ab9603f to
1ea0d8b
Compare
smackesey
force-pushed
the
windows/components/entry-point-error
branch
from
588c249 to
0f097b6
Compare
smackesey
force-pushed
the
graphite-base/27530
branch
from
1ea0d8b to
ccae30f
Compare
smackesey
force-pushed
the
windows/components/entry-point-error
branch
from
0f097b6 to
a289baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently if there is an error when loading a
dagster-componentsentry point, the whole process terminates unceremoniously with an ugly error.This PR changes this behavior:
Entry points are loaded in a try-catch block. Any error loading an entry point causes a warning to be written to stdout about the failing entry point, and the entry point to be passed over so that the whole system doesn't blow up. The warning shows up in the
dgoutput.How I Tested These Changes
New unit test and manually (running
dg component-type listin an env with a bad entry point).