Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExoPlayer #62

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Use ExoPlayer #62

merged 6 commits into from
Jan 24, 2024

Conversation

damontecres
Copy link
Owner

Closes #6
Closes #18
Workaround for #59 (av1 files are always transcoded)

Adds using ExoPlayer instead of the default player. There's a setting to toggle between the two if you need the default for some reason.

When using the ExoPlayer, it is recommended to use HLS or DASH for transcoded streams (can be changed in settings). HLS is the default now. From my testing on my setup, HLS tends to start playing faster and seeks faster, so that's why it's the default now.

With ExoPlayer and HLS/DASH, videos that needs to be transcoded now play & seek successfully!

The ExoPlayer UI is different and I'd like to change it a bit, but getting a working player is more important, so I'll follow up with UI changes.

@damontecres damontecres added enhancement New feature or request user interface Relates to the app's user interface/experience labels Jan 23, 2024
@damontecres damontecres merged commit 212a755 into main Jan 24, 2024
2 checks passed
@damontecres damontecres deleted the feat/exo-player branch January 24, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user interface Relates to the app's user interface/experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Can't get rid of progress bar [BUG] - Non-direct stream video playback issues
1 participant