bot: Update snsdemo to release-2025-02-12 #6422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pr-automation-bot-public[bot]](https://avatars.githubusercontent.com/u/59101585?s=60&v=4){kind=small}
pr-automation-bot-public
bot
requested review from
dskloetd,
mstrasinskis and
yhabib
dskloetd
approved these changes
Feb 14, 2025
|
snsdemo no longer creates an exchange rate proposal. We'll need to use a different filter to test. |
1 task
|
Replaced by #6425 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
# Motivation The [automatic snsdemo update PR](#6422) [failed](https://github.com/dfinity/nns-dapp/actions/runs/13322014060/job/37208355756?pr=6422) because an exchange rate proposal is no longer created during snapshot creation. # Changes 1. Update snsdemo. 2. Change the e2e test to use a different proposal type (ProtocolCanisterManagement). # Tests Fixed. # Todos - [ ] Add entry to changelog (if necessary). not necessary --------- Co-authored-by: gix-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to keep the testing environment, provided by snsdemo, up to date.
Changes
snsdemoversion inconfig.json.dfxversion indfx.jsonmatchessnsdemo.Tests
CI should pass.