Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snsdemo to release-2025-02-12 (+fix e2e test) #6425

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Update snsdemo to release-2025-02-12 (+fix e2e test) #6425

merged 4 commits into from
Feb 14, 2025

Conversation

dskloetd
Copy link
Contributor

Motivation

The automatic snsdemo update PR failed because an exchange rate proposal is no longer created during snapshot creation.

Changes

  1. Update snsdemo.
  2. Change the e2e test to use a different proposal type (ProtocolCanisterManagement).

Tests

Fixed.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review February 14, 2025 09:45
@dskloetd dskloetd requested a review from a team as a code owner February 14, 2025 09:45
@dskloetd dskloetd enabled auto-merge February 14, 2025 09:46
@dskloetd dskloetd mentioned this pull request Feb 14, 2025
Closed
mstrasinskis
mstrasinskis approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dskloetd dskloetd added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 20e89b7 Feb 14, 2025
32 checks passed
@dskloetd dskloetd deleted the kloet/exchange-snsdemo branch February 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dskloetd @mstrasinskis @gix-bot