-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject all daily events in import #3432
Conversation
8c60a72
to
5327e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! The code runs as expected and didn't cause problems. I only have one concern / one thing we should think of.
I imported the test calendar from Nextcloud that we used to test the imports. In there we have one event that repeats every day and one that repeats every two days. Both failed to be imported. I take it that this is expected. I just want to double check with @osmers and/or @hauf-toni if this is really what we want :)
I can see the problem that this is not very transparent for municipalities bcs they cannot see the import option and which events failed). On the other hand, so far we have no municipality using the import function (I think)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
5327e5a
to
8ef6157
Compare
Short description
This PR changes the event import functionality so no event with daily recurrence can be imported.
Proposed changes
Side effects
Resolved issues
Fixes: #3431
Pull Request Review Guidelines