Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the docs and add examples in the docs #228

Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix the docs and add examples in the docs #228

merged 2 commits into from
Jun 8, 2023

Conversation

JulienCalbert
Copy link
Collaborator

@JulienCalbert JulienCalbert commented Jun 8, 2023

@JulienCalbert JulienCalbert requested a review from adrienbanse June 8, 2023 14:40
@codecov-commenter
Copy link

Codecov Report

Merging #228 (63f82bc) into master (e763a5a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   41.91%   41.91%           
=======================================
  Files          58       58           
  Lines        4423     4423           
=======================================
  Hits         1854     1854           
  Misses       2569     2569           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@adrienbanse adrienbanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulienCalbert, I'll maybe just open an issue to add a little more comments in the examples in the doc

@adrienbanse
Copy link
Collaborator

@JulienCalbert Seems to be a conflict between the variable name time and Libc.time in the new example with lazy ellipsoids abstractions

@JulienCalbert
Copy link
Collaborator Author

yes good idea, I wrote the examples quickly

@adrienbanse adrienbanse merged commit aa58d60 into master Jun 8, 2023
@JulienCalbert JulienCalbert deleted the jc-clean branch June 9, 2023 07:21
@adrienbanse adrienbanse mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants