Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the starkli interaction process using katana as the local node #175

Closed
wants to merge 4 commits into from

Conversation

JameWade
Copy link
Contributor

@JameWade JameWade commented Jan 8, 2024

Run the katana local node, configure the node account to starkli, use starkli to deploy the contract to the katana node, and interact with the contract

@ponderingdemocritus
Copy link
Contributor

Looking good! Could you make it more apparent that you can use sozo or starkli? Also provide some context about starkli would be helpful

@JameWade
Copy link
Contributor Author

Looking good! Could you make it more apparent that you can use sozo or starkli? Also provide some context about starkli would be helpful

Okay, thank you for your opinion, I will revise it again

@JameWade
Copy link
Contributor Author

Looking good! Could you make it more apparent that you can use sozo or starkli? Also provide some context about starkli would be helpful

I have completed some content, please give some of your opinions, I will continue to work hard to improve

@ponderingdemocritus
Copy link
Contributor

@JameWade The book has been updated to a different base. Could you just copy the section into the new structure.

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
book ✅ Ready (Inspect) Visit Preview Jan 24, 2024 0:17am

@JameWade
Copy link
Contributor Author

@JameWade The book has been updated to a different base. Could you just copy the section into the new structure.

Of course, I've already merged it

@ponderingdemocritus
Copy link
Contributor

it still is pointing to the rust-book. Could you include it into the new structure and create a menu item in the config

3. Declare contract

```console
starkli declare target/dev/test_Vote.sierra.json --compiler-version 2.1.0 --rpc http://0.0.0.0:5050 --account ~/.starkli-wallets/deployer/account0_account.json --keystore ~/.starkli-wallets/deployer/account0_keystore.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion, we may show to the user how to use environment variables. This can make the commands way shorter, and educate the user on good practices.

Copy the vote contract to lib.cairo

```console
/// @dev Core Library Imports for the Traits outside the Starknet Contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if a simpler contract can be more understandable for new comers.

touch ~/.starkli-wallets/deployer/account0_account.json
```

3. Copy the following content into the json file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice to use account file for now, due to starkli incompatibility.
Once we're again compatible with starkli, we should also show to users that they can use --katana0 account for instance.

@gianalarcon
Copy link
Collaborator

@JameWade Do you still plan to work on this PR. Otherwise I can give you a hand.

@JameWade
Copy link
Contributor Author

JameWade commented Mar 4, 2024

@JameWade Do you still plan to work on this PR. Otherwise I can give you a hand.

Sure, but what should I do next?

@gianalarcon
Copy link
Collaborator

@JameWade Sorry I tried to commit on your PR but I got rejected. Please let's move here #216

@ponderingdemocritus
Copy link
Contributor

closing this as it's still based off the rust book. Please recreate PR based off the new book

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants