Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starkli-Scarb interaction using katana #216

Merged
merged 20 commits into from
Mar 20, 2024
Merged

Conversation

gianalarcon
Copy link
Collaborator

@gianalarcon gianalarcon commented Mar 4, 2024

Based on the PR #175
Closes issue #67

  • Scarb
  • Starkli

@ponderingdemocritus @glihm I will need your feedback here

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
book ✅ Ready (Inspect) Visit Preview Mar 15, 2024 2:33am

Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianalarcon good job on that, a first review here. 👍

docs/pages/toolchain/katana/interact.md Show resolved Hide resolved
docs/pages/toolchain/katana/interact.md Outdated Show resolved Hide resolved
docs/pages/toolchain/katana/interact.md Outdated Show resolved Hide resolved
docs/pages/toolchain/katana/interact.md Outdated Show resolved Hide resolved
@gianalarcon gianalarcon marked this pull request as ready for review March 12, 2024 23:21

To install `Katana`, use the `dojoup` installer from the command line:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move these to a 'snippets' directory and we can reuse the snippet everywhere. https://vocs.dev/docs/guides/code-snippets

Also could you do it for other CLI commands that are generalised

@gianalarcon gianalarcon requested a review from glihm March 19, 2024 06:20
@ponderingdemocritus ponderingdemocritus merged commit 082b48a into main Mar 20, 2024
1 check passed
@ponderingdemocritus ponderingdemocritus deleted the starkli-scarb branch March 20, 2024 02:16
@glihm glihm mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants