Allow to override build date with SOURCE_DATE_EPOCH #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1435 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 50 50
Lines 8763 8763
Branches 1034 1034
=======================================
Hits 5724 5724
Misses 3039 3039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The date is not really necessary but it was nice to have. I understand the need for reproducible builds, so I approve these changes. If possible I would like to keep support for BSD. |
to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This date call works with different flavors of date (GNU, BSD, other). This patch was done while working on reproducible builds for openSUSE.
|
I updated the patch to also support BSD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override build date with
SOURCE_DATE_EPOCHto make builds reproducible.See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call works with different flavors of date (GNU, BSD, other).
Alternatively the date could be dropped completely to simplify the code.
This patch was done while working on reproducible builds for openSUSE.