-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Backend
concept for data persistence
#370
Open
s-heppner
wants to merge
24
commits into
eclipse-basyx:develop
Choose a base branch
from
rwth-iat:improve/data_persistence
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor Backend
concept for data persistence
#370
s-heppner
wants to merge
24
commits into
eclipse-basyx:develop
from
rwth-iat:improve/data_persistence
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend
concept for data persistence
For reference: Some of the discussions of this PR are at rwth-iat/basyx-python-sdk#58 as well. |
Looks good to me |
This was referenced Jan 20, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
These changes are not backward compatible and therefore require a
2.0.0
release!Previously, we tried to use the
Backend
concept for both data persistence and data integration.This led to complicated cross-dependencies, architectures and badly maintainable code.
Now, we decided to split these two concepts and use the existing
Backend
ObjectStore
s for just the data persistence.Concretely, this PR does the following:
Backend
class (backends.py), as well as their concrete implementations (CouchDBBackend
,LocalFileBackend
), as they are no longer neededReferable.source
attribute, as it was only needed for theBackend
classReferable.source
attribute, such asReferable.update()
andReferable.commit()
(base.py), as they were used together to perform the data integration.