Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/data persistence #58

Closed
wants to merge 24 commits into from
Closed

Improve/data persistence #58

wants to merge 24 commits into from

Conversation

shenchenruwo
Copy link

@shenchenruwo shenchenruwo commented Nov 8, 2024 •
edited
Loading

Previously, we tried to use the Backend concept for both data persistence and data integration.
Now, we decided to split these two concepts and use the existing Backend ObjectStores for just the data persistence.

Concretely, this PR does the following:

  1. Remove the abstract Backend class (backends.py), as well as their concrete implementations (CouchDBBackend, LocalFileBackend), as it is no longer needed
  2. Remove the Referable.source attribute, as it was only needed for the Backend class
  3. Remove methods related to the Referable.source attribute, such as update() and commit() (base.py), as they were used together to perform the data integration.
  4. Adapt other related codes such as tutorials and tests to reflect these changes
  5. Adapt documentation to reflect these changes

shenchenruwo and others added 21 commits November 7, 2024 11:22
@shenchenruwo
remove source and CouchDBBackend in couchdb.py
25a621e
@shenchenruwo
delete import backends
2f0a229
@shenchenruwo
remove LocalFileBackend class
36d2bba
@shenchenruwo
adapt replication checking
12dba7d
@shenchenruwo
remove source related code in local_file.py
9798fb2
@shenchenruwo
change do_requrest to non-public
46a6827
@shenchenruwo
remove source, update and commit from Referable
7f119e4
@shenchenruwo
delete backends.py
483f6ad
@shenchenruwo
remove update and commit from couchdb tutorial
b892047
@shenchenruwo
Merge branch 'eclipse-basyx:main' into improve/data_persistence
8eb27c8
@shenchenruwo
adapt test_couchdb and test_local_file
d2bf73c
@shenchenruwo
adapt test_backends and test_base
ed2108f
@shenchenruwo
adapt documentation
e17940e
@shenchenruwo
delete import backends in base.py
e421655
@shenchenruwo
remove source in test_base
f6e4555
@shenchenruwo
delete test_parse_source
c2e3e69
@shenchenruwo
remove update and commit in multiple files
766686b
@shenchenruwo
adapt documentation about update and commit
880331e
@shenchenruwo
adapt docs
cd234c0
@shenchenruwo
delete missed update in test_base
8ae2fc6
@shenchenruwo
adapt couchdb safe_delete test
f12cd5d
s-heppner
s-heppner requested changes Jan 20, 2025
View reviewed changes
sdk/basyx/aas/backend/__init__.py Outdated Show resolved Hide resolved
sdk/basyx/aas/examples/tutorial_backend_couchdb.py Outdated Show resolved Hide resolved
sdk/basyx/aas/model/provider.py Outdated Show resolved Hide resolved
sdk/test/backend/test_couchdb.py Outdated Show resolved Hide resolved
sdk/test/backend/test_couchdb.py Outdated Show resolved Hide resolved
sdk/test/backend/test_local_file.py Outdated Show resolved Hide resolved
sdk/test/backend/test_local_file.py Outdated Show resolved Hide resolved
@s-heppner s-heppner changed the base branch from main to develop January 20, 2025 09:32
@s-heppner s-heppner force-pushed the improve/data_persistence branch from aa8eff5 to e8a4d1f Compare January 20, 2025 10:12
@s-heppner s-heppner force-pushed the improve/data_persistence branch from e8a4d1f to 4c5217d Compare January 20, 2025 10:16
@s-heppner s-heppner mentioned this pull request Jan 20, 2025
Open
@s-heppner
Copy link

See eclipse-basyx/basyx-python-sdk#370.

@s-heppner s-heppner closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-heppner s-heppner s-heppner requested changes

Assignees

@s-heppner s-heppner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenchenruwo @s-heppner