-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup retrieval server and client #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
reviewed
Jan 16, 2025
aidan46
reviewed
Jan 17, 2025
aidan46
reviewed
Jan 17, 2025
jmg-duarte
approved these changes
Jan 17, 2025
This was
linked to
issues
Jan 17, 2025
aidan46
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR implements the retrieval server and client. The server is running a p2p node that listens for block requests. The client runs a temporary p2p node that is used to request the needed blocks by the provider. The new blocks are requested until we receive a whole unixfs DAG tree.
The next step is integrating the server with the storage provider.
Important points for reviewers
Start a simple server as a proof of concept:
cargo run --package polka-storage-retrieval --example simple_server --all-features
Request content from the server:
cargo run --bin polka-fetch -- --provider /ip4/127.0.0.1/tcp/8989 --output ./download.car --payload-cid bafybeiefli7iugocosgirzpny4t6yxw5zehy6khtao3d252pbf352xzx5q
Note: For content extraction, you should use
go-car
. The reason is that our mater crate currently doesn't know how to extract content from the encoded unixfs dag tree.Checklist