Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 bug dnam qc pipeline sex check thresholds #284

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ejh243
Copy link
Owner

@ejh243 ejh243 commented Dec 19, 2024

Description

This pull request will make the sex check in the DNAm preprocessing pipeline more robust against hard coded thresholds, and more adaptable in the long term for changes to the technology.

It does require a certain number of samples basic testing would indicate at least 20, and is designed for the situation where you have at least two sexes present in the data. While I have tried to account for a single sex dataset, I have not been able to test this. Equally the behaviour in this situation might require some further consideration.

Issue ticket number

This pull request is to address issue: #152 .

Type of pull request

  • Bug fix
  • New feature/enhancement
  • Code refactor
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code to check that it is functional
  • I have used linters to check for common sources of errors
  • I have implemented fail safes in my code to account for edge cases
  • I have made the corresponding changes to the documentation

@ejh243 ejh243 linked an issue Dec 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DNAm QC pipeline sex check thresholds
1 participant