Removed '$' sign from region check in publish_lambda.sh

[hvltaj]

Bug

What does this PR do?

Fixed bug in the publish_lambda.sh script which always set up gov as bucket region.

Why is it important?

Deployment script only works for gov regions in current state

Checklist

• [~~] My code follows the style guidelines of this project
• [~~] I have commented my code, particularly in hard-to-understand areas
• [~~] I have made corresponding changes to the documentation
• [~~] I have made corresponding change to the default configuration files
• [~~] I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.md

Author's Checklist

How to test this PR locally

Use deployment script to deploy Lambda.

Related issues

Closes #726

Use cases

Screenshots

Logs

[cla-checker-service]

💚 CLA has been signed

[zmoog]

Hey @hvltaj, thanks for contributing the fix.

Adding this to the next release.

[constanca-m]

This version should match the one inside share/version.py:

elastic-serverless-forwarder/share/version.py

Line 5 in 8be4fc4

version = "1.17.0"

Perhaps we should update the workflow to compare these, this should not pass...

[constanca-m]

But updating the version.py will also trigger a new release, which seems a bit unnecessary, since the dependencies are not changing (the dependencies can be seen here).

[zmoog]

Yeah, @constanca-m, you're right.

@hvltaj, the publish_lambda.sh is not part of the release; it's a supporting tool, so we can avoid updating the CHANGELOG.md and share/version.py files.

[kaiyan-sheng]

I updated the changelog after #803 is merged. Now it should match the version inside share/version.py.

[kaiyan-sheng]

ahh good point, ok I will take out the entry from CHANGELOG.md then!

[constanca-m]

I have created #807 to see how we can stop this from happening, or maybe ease this version update process a bit.