Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed '$' sign from region check in publish_lambda.sh #727

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Removed '$' sign from region check in publish_lambda.sh #727

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
365f0b7
Removed '$' sign from region check in publish_lambda.sh
hvltaj Jun 5, 2024
65fe1c2
Added entry to changelog
hvltaj Jun 5, 2024
1aac268
Merge branch 'main' into fix-deployment-script-gov-check
zmoog Sep 17, 2024
f933c1a
Merge branch 'main' into fix-deployment-script-gov-check
kaiyan-sheng Sep 23, 2024
fa33955
Update CHANGELOG.md
kaiyan-sheng Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion publish_lambda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ trap 'rm -rf ${TMPDIR}' EXIT
aws s3api get-bucket-location --bucket "${BUCKET}" --region "${REGION}" || aws s3api create-bucket --acl private --bucket "${BUCKET}" --region "${REGION}" --create-bucket-configuration LocationConstraint="${REGION}"

# Check if region is in AWS GovCloud and create bucket arn
if [[ ${REGION} == *"$gov"* ]]; then
if [[ ${REGION} == *"gov"* ]]; then
BUCKET_ARN="arn:aws-us-gov:s3:::${BUCKET}"
AWS_OR_AWS_GOV="aws-us-gov"
else
Expand Down