[Fleet] limit agent list total count to 10k #135026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Jun 23, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Jun 23, 2022
(cherry picked from commit d61253a)
kibanamachine
pushed a commit
that referenced
this pull request
Jun 23, 2022
(cherry picked from commit d61253a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jun 27, 2022
(cherry picked from commit d61253a) Co-authored-by: Julia Bardi <[email protected]>
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Jun 27, 2022
* limit agent list total count to 10k (#135026) (cherry picked from commit d61253a) * Fixed checks * Update index.tsx * fixed import Co-authored-by: Julia Bardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvement for #91562
Limiting total size of agent list page to 10k, so that users can't click on page > 500 (for pageSize 20).
This is a small improvement as agreed in comment, because implementing pagination after 10k items are more complex, and not in scope for now.
Tested locally by setting limit to 100, enrolling 200 agents with horde, and checking that there are 5 visible pages only (for pageSize: 20). The page count is automatically adjusted when changing pageSize, e.g. max 2 pages for pageSize 50.