Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Agent activity #140510

Merged
merged 19 commits into from
Sep 15, 2022
Merged

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Sep 12, 2022

Summary

Resolves #140267

Added agent activity flyout following the new design.

  • Agent activity button on agent list page, next to Add agent buttons.
  • Flyout showing In progress and completed actions in descending time order.
  • Upgrade callout and abort moved to flyout
  • Added tour for first time after action is taken from UI

Pending:

  • adding tests
  • (Done) update texts everywhere with i18n
  • openapi update

image

image

image

image

Checklist

Delete any items that are not applicable to this PR.

@juliaElastic juliaElastic self-assigned this Sep 12, 2022
@juliaElastic juliaElastic added release_note:feature Makes this part of the condensed release notes v8.5.0 labels Sep 12, 2022
@juliaElastic juliaElastic marked this pull request as ready for review September 13, 2022 11:59
@juliaElastic juliaElastic requested a review from a team as a code owner September 13, 2022 11:59
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few patterns in the code here that I think are worth changing. Haven't gotten a chance to pull down locally and test (will do so tomorrow), but overall things are looking great here. Thanks for putting this together so quickly @juliaElastic!

@nchaulet
Copy link
Member

nchaulet commented Sep 14, 2022

Should we clean somehow the unenroll action when the user force unenroll an agent? (probably a follow up issue)

Here I unenrolled an offline agent, than force unenrolled and the UI is stuck with this
Screen Shot 2022-09-14 at 4 54 57 PM

@juliaElastic
Copy link
Contributor Author

juliaElastic commented Sep 15, 2022

Should we clean somehow the unenroll action when the user force unenroll an agent? (probably a follow up issue)

Here I unenrolled an offline agent, than force unenrolled and the UI is stuck with this

Good point, I think this is an existing issue made visible with the activity flyout. This could be improved by kibana querying any in progress unenroll actions for the agents being force unenrolled, and making them completed. I would take this to a separate issue.

Created: #140794

There is a similar issue with stuck in progress actions in case of validation failures, commented here: #141567

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@juliaElastic
Copy link
Contributor Author

@kpollich are you ready to approve? I updated the requested changes.

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed so LGTM 🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 719 721 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 869.6KB 879.4KB +9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 105.9KB 105.9KB -3.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@ghost
Copy link

ghost commented Sep 26, 2022

Hi @juliaElastic ,

We have created below 13 test cases for this feature under our Fleet Test Suite:

Query

  • Could you please confirm when and how many times will 'Agent activity history' pop would be shown as we are getting the pop-up inconsistently many times.

Please review the test cases and let us know if we are missing anything.

Thanks!

@juliaElastic
Copy link
Contributor Author

@prachigupta-qasource One more scenario can be added: update agent tags will show up now in Agent activity as well: #141376

Could you please confirm when and how many times will 'Agent activity history' pop would be shown as we are getting the pop-up inconsistently many times.

The tour should show up for the first time one of these actions are taken. After that, the tour should be hidden on that cluster (there is a ui setting saved for this).

@ghost
Copy link

ghost commented Sep 29, 2022

Hi @juliaElastic ,

Thank you for the update.

We have created below 01 test case for this feature under our Fleet Test Suite:

[C168020]: Validate that ‘X agent/agents updated tags’ is shown on ‘Agent activity’ flyout on updating tags for X agent/agents

Please review the test case and let us know if we are missing anything.

Thanks!

@ghost
Copy link

ghost commented Oct 4, 2022

Hi Team,

We have executed 15 testcases for this feature under our Fleet Test run at Fleet 8.5.0-BC2 Feature test plan.

Below are the observations:

Build details:

Version: 8.5.0 BC2
Build: 56806
Commit: dc769f45a5a6dafb0a8c8f0c0cabcced4df45e11

Thanks!

@ghost
Copy link

ghost commented Nov 7, 2022

Hi @juliaElastic,

As per this issue #144299, we have created 01 test case for this feature under our Fleet Test Suite:

Please let us know if anything else is required from our end.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting QA:Validated Issue has been validated by QA release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Agent activity flyout
8 participants