-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Agent activity #140510
[Fleet] Agent activity #140510
Conversation
Pinging @elastic/fleet (Team:Fleet) |
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_button.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few patterns in the code here that I think are worth changing. Haven't gotten a chance to pull down locally and test (will do so tomorrow), but overall things are looking great here. Thanks for putting this together so quickly @juliaElastic!
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_button.tsx
Outdated
Show resolved
Hide resolved
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_button.tsx
Show resolved
Hide resolved
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_button.tsx
Show resolved
Hide resolved
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout.tsx
Show resolved
Hide resolved
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx
Show resolved
Hide resolved
Good point, I think this is an existing issue made visible with the activity flyout. This could be improved by kibana querying any in progress unenroll actions for the agents being force unenrolled, and making them completed. I would take this to a separate issue. Created: #140794 There is a similar issue with stuck in progress actions in case of validation failures, commented here: #141567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
@kpollich are you ready to approve? I updated the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed so LGTM 🚀
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@prachigupta-qasource One more scenario can be added: update agent tags will show up now in Agent activity as well: #141376
The tour should show up for the first time one of these actions are taken. After that, the tour should be hidden on that cluster (there is a ui setting saved for this). |
Hi @juliaElastic , Thank you for the update. We have created below 01 test case for this feature under our Fleet Test Suite: Please review the test case and let us know if we are missing anything. Thanks! |
Hi Team, We have executed 15 testcases for this feature under our Fleet Test run at Fleet 8.5.0-BC2 Feature test plan. Below are the observations:
Build details:
Thanks! |
Hi @juliaElastic, As per this issue #144299, we have created 01 test case for this feature under our Fleet Test Suite: Please let us know if anything else is required from our end. Thanks! |
Summary
Resolves #140267
Added agent activity flyout following the new design.
Pending:
Checklist
Delete any items that are not applicable to this PR.