Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v99.0.0 #206046

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Upgrade EUI to v99.0.0 #206046

merged 3 commits into from
Jan 14, 2025

Conversation

acstll
Copy link
Contributor

@acstll acstll commented Jan 9, 2025

98.2.1-borealis.299.0.0-borealis.1

Resolves #202287

Questions? Please see our Kibana upgrade FAQ.


@elastic/eui

v99.0.0

  • Added two new icons: createGenericJob and createGeoJob (#8248)
  • Added new icon section (#8261)

Bug fixes

Breaking changes

  • Removed EuiPopover's deprecated hasDragDrop prop. Use usePortal on any child EuiDraggable instead (#8256)

@elastic/eui-theme-borealis

v0.0.8

  • [Visual Refresh] Correct severity palette order for Amsterdam (#8254)
  • [Visual Refresh] Add behindText vis color tokens (#8253)

@acstll acstll added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v9.0.0 labels Jan 9, 2025
@acstll
Copy link
Contributor Author

acstll commented Jan 9, 2025

/ci

@acstll
Copy link
Contributor Author

acstll commented Jan 13, 2025

fyi, an unexpected error in EUI is causing all these failing tests, not the actual changes listed in the changelog — we're taking care of it and will open a new PR soon (or update this one)

🙏

@acstll
Copy link
Contributor Author

acstll commented Jan 13, 2025

99.0.0-borealis.1 has been released with a fix (thank you @tkajtoch)

@acstll
Copy link
Contributor Author

acstll commented Jan 13, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 508.0KB 508.4KB +394.0B
dashboard 687.9KB 688.3KB +394.0B
kubernetesSecurity 257.9KB 258.3KB +394.0B
maps 3.1MB 3.1MB +394.0B
ml 4.7MB 4.7MB +394.0B
visTypeVega 1.9MB 1.9MB +394.0B
total +2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.9MB 5.9MB -280.0B
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +460.0B
total +180.0B

History

@acstll acstll marked this pull request as ready for review January 14, 2025 11:18
@acstll acstll requested a review from a team as a code owner January 14, 2025 11:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@acstll
Copy link
Contributor Author

acstll commented Jan 14, 2025

@kertal this one should be ready 🙂 (re: #202287) — do you know who else I could ping for approval?

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in quickly, and it resolves #202287

you can add a resolves #202287 to the description, then it's auto closed.

Thx a lot for the fix!

@kertal
Copy link
Member

kertal commented Jan 14, 2025

@kertal this one should be ready 🙂 (re: #202287) — do you know who else I could ping for approval?

It seems the change just triggers one codeowner team? and the changes are new icons, the fix I've checked and the breaking change is not used in Kibana anymore, and euiColorSeverity doesn't seem to be used? So don't think anybody else than needs to be pinged for approval?

@acstll acstll merged commit 902820e into elastic:main Jan 14, 2025
8 checks passed
@acstll acstll deleted the eui/v99.0.0 branch January 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] JS warnings when opening the document flyout in Discover
4 participants