-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Getting Started vignette #234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 8 8
Lines 587 587
=======================================
Hits 580 580
Misses 7 7 ☔ View full report in Codecov by Sentry. |
1ae1013
to
64bbf61
Compare
64bbf61
to
70af9b0
Compare
1d31a12
to
24774ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, looks really great. Lots of little suggestions, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I see Seb has already added several comments, so just a few additional minor points from me.
Thanks for taking a look. |
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Adam Kucharski <[email protected]>
d020306
to
150850d
Compare
@sbfnk Could you approve if you're happy? |
This PR improves the Getting Started vignette to reduce the technical barrier to understanding the original text. In particular, It
Note that this vignette contains styling that is only properly viewed by building the website using
pkgdown::build_site()
in your local copy of this repository.