Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename simulate_summary() to simulate_chain_stats() for clarity #235

Merged
merged 8 commits into from
May 8, 2024

Conversation

jamesmbaazam
Copy link
Member

This PR closes #118 by renaming simulate_summary() to simulate_chain_stats() to remove the confusion around its name and the role of the summary.epichains method.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (07f6087) to head (45574e3).
Report is 27 commits behind head on main.

❗ Current head 45574e3 differs from pull request most recent head 0bfded5. Consider uploading reports for the commit 0bfded5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files           8        8           
  Lines         584      584           
=======================================
  Hits          577      577           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesmbaazam jamesmbaazam requested a review from sbfnk May 6, 2024 21:38
@jamesmbaazam jamesmbaazam force-pushed the rename-simulate_summary branch from 0bfded5 to 5951ff6 Compare May 7, 2024 11:43
@jamesmbaazam jamesmbaazam changed the title Rename simulate_summary() to simulate_chain_stats() Rename simulate_summary() to simulate_chain_stats() for clarity May 7, 2024
@jamesmbaazam
Copy link
Member Author

jamesmbaazam commented May 8, 2024

I'm going to go ahead and merge this PR as it was just a renaming refactor. Any issues with it can be raised an issue.

@jamesmbaazam jamesmbaazam merged commit a102c45 into main May 8, 2024
@jamesmbaazam jamesmbaazam deleted the rename-simulate_summary branch May 8, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name options for simulate_summary()
3 participants