feat: Expose private class hashing functionality #2465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: we require a way to compute the "hinted class hash" used in the Cairo 0 class hashing procedure for the Starknet OS. Pathfinder computes this value but does not expose the computation. Solution: extract the hash computation in a new public function `compute_cairo_hinted_class_hash()`. Make the `json` module and the JSON parsing function public as well to give callers access to the types required to compute this hash.
|
Hi! Thanks for bringing this to our attention. We've created an issue to tackle this. Feel free to subscribe to it to receive updates as we move forward with this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes Pathfinder's class hashing internals for use in SNOS.
Class hashing is very nuanced, and Pathfinder is one of the only public implementations in rust that provides this functionality. However, it was kept private, so we have been using a fork of Pathfinder in which we exposed this functionality for our use and have been maintaining it since.
However, for projects which use SNOS as a dependency, this creates conflicting/duplicated Pathfinder crates in the dependency tree which is tricky to solve. If possible, it would be great to include this in the main codebase so that SNOS can depend on official crates through
crates.ioand avoid such conflicts.Delete once completed:
CHANGELOG.md