Use v4 of the upload-artifact action #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v3 upload-artifact action is deprecated and will be removed in the future. This PR updates the action to use v4. Note possibly breaking changes given in https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. I haven't reviewed these carefully, but at a glance I don't see use of these patterns.
danrosen25
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Can you change actions/checkout@v3 to actions/checkout@v4 as well? and actions/cache@v3 to actions/cache@v4
- workflows/build-esmf-docs.yml: uses: actions/checkout@v3
- workflows/build-esmf-docs.yml: uses: actions/upload-artifact@v3
- workflows/build-esmf-docs.yml: uses: actions/checkout@v3
- workflows/build-esmpy-docs.yml: uses: actions/checkout@v3
- workflows/build-esmpy-docs.yml: uses: actions/upload-artifact@v3
- workflows/build-esmpy-docs.yml: uses: actions/checkout@v3
- workflows/test-coverage.yml: uses: actions/checkout@v3
- workflows/test-coverage.yml: uses: actions/upload-artifact@v3
- workflows/api-change.yml: uses: actions/checkout@v3
- workflows/api-change.yml: uses: actions/upload-artifact@v3
- workflows/test-build-spack.yml: uses: actions/checkout@v3
- workflows/test-build-spack.yml: uses: actions/cache@v3
- workflows/test-build-spack.yml: uses: actions/checkout@v3
- workflows/test-build-spack.yml: uses: actions/upload-artifact@v3
Suggested by Dan Rosen
Suggested by Dan Rosen
|
Thanks @danrosen25 - I hadn't realized those were connected. I think I got them all. |
billsacks
added a commit
to esmf-org/esmf-test-summary
that referenced
this pull request
Jan 16, 2025
Inspired by comment from Dan Rosen: esmf-org/esmf#344 (review)
|
@danrosen25 I see a thumbs up reaction but I'll wait to merge until you change "changes requested" to "approved". |
danrosen25
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v3 upload-artifact action is deprecated and will be removed in the future (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). This PR updates the action to use v4.
Note possibly breaking changes given in
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. I haven't reviewed these carefully, but at a glance I don't see use of these patterns. But @danrosen25 and @uturuncoglu you might have a better sense of this than I do.