Update junit-vintage-engine to 5.11.4 #1292
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request involves a minor update to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
project/depends.scala
Outdated
| val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4" | ||
| val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.3") | ||
| val junitTest = libraryDependencies += junitVintage % Test |
There was a problem hiding this comment.
💡 Codebase verification
Update junit-platform-engine to version 1.11.4
The latest compatible version of junit-platform-engine for JUnit 5.11.4 is 1.11.4. Please update the dependency version to maintain consistency:
"org.junit.platform" % "junit-platform-engine" % "1.11.4"🔗 Analysis chain
Version mismatch between JUnit components
While updating junit-vintage-engine to 5.11.4 is good, there's a potential version mismatch with junit-platform-engine which remains at 1.11.3. These components are typically versioned together to ensure compatibility.
Let's verify the recommended version combinations:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check Maven Central for the latest junit-platform-engine version that matches junit-vintage-engine 5.11.4
# Check the latest versions
curl -s "https://search.maven.org/solrsearch/select?q=g:org.junit.vintage+AND+a:junit-vintage-engine+AND+v:5.11.4&rows=1&wt=json" | jq -r '.response.docs[0].v'
curl -s "https://search.maven.org/solrsearch/select?q=g:org.junit.platform+AND+a:junit-platform-engine+AND+v:1.11*&rows=1&wt=json" | jq -r '.response.docs[0].v'
Length of output: 338
| @@ -22,7 +22,7 @@ object depends { | |||
| val scalaXml = libraryDependencies += "org.scala-lang.modules" %%% "scala-xml" % "2.3.0" | |||
|
|
|||
| // used in specs2-junit | |||
| val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3" | |||
| val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4" | |||
There was a problem hiding this comment.
💡 Codebase verification
Version mismatch detected between JUnit dependencies
There appears to be a version mismatch in the JUnit dependencies:
- junit-vintage-engine is being updated to 5.11.4
- junit-platform-engine is still at 1.11.3
These versions should typically be aligned as they are part of the same JUnit 5 platform. Consider updating both dependencies to the same version.
🔗 Analysis chain
Patch version update looks good
The update from 5.11.3 to 5.11.4 is a patch version change, which typically includes bug fixes and security updates without breaking changes.
Let's check for any breaking changes or security fixes in this version:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the changelog and security advisories for junit-vintage-engine 5.11.4
# Check for security advisories
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: MAVEN, package: "junit-vintage-engine") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
Length of output: 355
Script:
#!/bin/bash
# Let's check if there are any other JUnit dependencies in the project
rg -l "junit" --type scala --type sbt
# Also check for any test files that might be using JUnit
fd -e scala -e java . -x grep -l "org.junit"
Length of output: 1216
Script:
#!/bin/bash
# Let's check the content of the JUnit-related files to understand the usage
cat ./project/depends.scala
# Also check if there are any specific version requirements or constraints
rg -A 3 -B 3 "junit" ./project/depends.scala
Length of output: 3209
About this PR
📦 Updates org.junit.vintage:junit-vintage-engine from
5.11.3to5.11.4Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
Summary by CodeRabbit
junit-vintage-enginedependency from 5.11.3 to 5.11.4.