Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update junit-vintage-engine to 5.11.4 #1292

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Update junit-vintage-engine to 5.11.4 #1292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d90359d
Update junit-vintage-engine to 5.11.4
scala-steward Dec 17, 2024
1bfe9c7
Merge branch 'main' into update/junit-vintage-engine-5.11.4
etorreborre Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/depends.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object depends {
val scalaXml = libraryDependencies += "org.scala-lang.modules" %%% "scala-xml" % "2.3.0"

// used in specs2-junit
val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3"
val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version mismatch detected between JUnit dependencies

There appears to be a version mismatch in the JUnit dependencies:

  • junit-vintage-engine is being updated to 5.11.4
  • junit-platform-engine is still at 1.11.3

These versions should typically be aligned as they are part of the same JUnit 5 platform. Consider updating both dependencies to the same version.

🔗 Analysis chain

Patch version update looks good

The update from 5.11.3 to 5.11.4 is a patch version change, which typically includes bug fixes and security updates without breaking changes.

Let's check for any breaking changes or security fixes in this version:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the changelog and security advisories for junit-vintage-engine 5.11.4

# Check for security advisories
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: MAVEN, package: "junit-vintage-engine") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Length of output: 355

Script:

#!/bin/bash
# Let's check if there are any other JUnit dependencies in the project
rg -l "junit" --type scala --type sbt

# Also check for any test files that might be using JUnit
fd -e scala -e java . -x grep -l "org.junit"

Length of output: 1216

Script:

#!/bin/bash
# Let's check the content of the JUnit-related files to understand the usage
cat ./project/depends.scala

# Also check if there are any specific version requirements or constraints
rg -A 3 -B 3 "junit" ./project/depends.scala

Length of output: 3209

val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")
val junitTest = libraryDependencies += junitVintage % Test

Expand Down
Loading