Add GHA build, rename scope to @evidenceprime #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salceson
approved these changes
Jan 23, 2024
Comment on lines
+32
to
+33
| - name: Build | ||
| run: yarn build |
There was a problem hiding this comment.
Can we add running tests before build + reporting results? If this is not possible, then we can remove permission for checks and statuses.
There was a problem hiding this comment.
Looks like tests here require credentials to some SaaS (or a local browser manually launched) to run.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@ep/buffer", | |||
| "name": "@evidenceprime/buffer", | |||
There was a problem hiding this comment.
This is about pipelines def: if we are removing this, let's remove pipeline on Azure side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.