Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA build, rename scope to @evidenceprime #1

Merged
merged 3 commits into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/workflows/ci.yml

This file was deleted.

45 changes: 45 additions & 0 deletions .github/workflows/cicd.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
on:
push:
branches:
- master
pull_request:
branches:
- master
workflow_dispatch:

jobs:
buildAndPublish:
name: Build and publish to NPM (GH)
runs-on: ubuntu-22.04
permissions:
contents: read
packages: write
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 20
cache: 'yarn'
registry-url: https://npm.pkg.github.com
- name: Install dependencies
run: yarn --frozen-lockfile
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Build
run: yarn build
Comment on lines +30 to +31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add running tests before build + reporting results? If this is not possible, then we can remove permission for checks and statuses.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests here require credentials to some SaaS (or a local browser manually launched) to run.

- name: Release
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
run: yarn release
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Notify Google Chat
uses: evidenceprime/google-chat-notifications@master
if: ${{ always() && github.event_name == 'push' }}
with:
title: "Buffer"
subtitle: ${{ github.event.head_commit.message }}
webhookUrl: ${{ secrets.GOOGLE_CHAT_WEBHOOK_URL }}
threadKey: QexDHE9oqjI
status: ${{ job.status }}
13 changes: 0 additions & 13 deletions .npmrc.tpl

This file was deleted.

22 changes: 0 additions & 22 deletions Dockerfile

This file was deleted.

40 changes: 0 additions & 40 deletions azure-pipelines.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions dist/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@ep/buffer",
"name": "@evidenceprime/buffer",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about pipelines def: if we are removing this, let's remove pipeline on Azure side.

"description": "Node.js Buffer API, for the browser",
"version": "6.0.9",
"version": "6.0.10",
"main": "./buffer.js",
"engines": {
"node": ">=8.0"
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@ep/buffer",
"name": "@evidenceprime/buffer",
"description": "Node.js Buffer API, for the browser",
"version": "6.0.9",
"version": "6.0.10",
"author": {
"name": "Feross Aboukhadijeh",
"email": "[email protected]",
Expand Down