Add a comment asking for feedback #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceddlyburge
approved these changes
Oct 3, 2022
jiegillet
force-pushed
the
jie-feedback-comment
branch
from
996c65a to
8fcb75e
Compare
|
@exercism/maintainers-admin would you approve this PR please? |
ErikSchierboom
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37.
Sister PR here.
If there are any essential or actionable comments, we automatically add an extra comment to ask for feedback.
If there is no comment, or if there are only informative or celebratory comments, we don't add anything.
This is still in draft because I need to fix the smoke tests, but they were changed in #39 so I would need to redo it anyway.