Elm Analyzer Comment: feedback request #2228
Conversation
github-actions
bot
added
track/elm
|
@exercism/reviewers can I get an approval? 🙇♂️ |
There was a problem hiding this comment.
See https://exercism.org/docs/building/markdown/markdown in regard to reference links.
| @@ -0,0 +1,4 @@ | |||
| # feedback request | |||
|
|
|||
| If this automated feedback doesn't look right, please [open an issue in the `exercism/elm-analyzer` repository](https://github.com/exercism/elm-analyzer/issues?q=is%%3Aissue+is%%3Aopen+sort%%3Aupdated-desc). | |||
There was a problem hiding this comment.
Are you sure that link is correct?
Also, it might be worthwhile to make a reference link instead: Updating it later will mean a cleaner diff, less noise.
There was a problem hiding this comment.
The link is correct, because the % are being escaped. It's really confusing, see #2196.
Thank you for the reference link suggestion.
|
|
||
| If this automated feedback doesn't look right, please [open an issue in the `exercism/elm-analyzer` repository][elm-analyzer-issues]. | ||
|
|
||
| [elm-analyzer-issues]: https://github.com/exercism/elm-analyzer/issues?q=is%%3Aissue+is%%3Aopen+sort%%3Aupdated-desc |
There was a problem hiding this comment.
I believe the link still needs to be updated: https://github.com/exercism/elm-analyzer/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc insted of with the double %.
There was a problem hiding this comment.
It probably works with rendering, something is being escaped, but does not work as is.
There was a problem hiding this comment.
Yes, like I mentioned, the rendering will escape the link and it should work as expected.
There was a problem hiding this comment.
Thanks for mentioning that, I just a few minutes ago fixed a problem with a link with two dashes that I had to escape as well, for rendering.
There was a problem hiding this comment.
Well it didn't work in the end, the comment doesn't appear -_-
Sister PR here.
@ceddlyburge
@mpizenberg