Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm Analyzer Comment: feedback request #2228

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Elm Analyzer Comment: feedback request #2228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0801823
Add feedback
jiegillet Oct 3, 2022
7560f61
Use reference link
jiegillet Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions analyzer-comments/elm/feedback_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# feedback request

If this automated feedback doesn't look right, please [open an issue in the `exercism/elm-analyzer` repository][elm-analyzer-issues].

[elm-analyzer-issues]: https://github.com/exercism/elm-analyzer/issues?q=is%%3Aissue+is%%3Aopen+sort%%3Aupdated-desc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the link still needs to be updated: https://github.com/exercism/elm-analyzer/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc insted of with the double %.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably works with rendering, something is being escaped, but does not work as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like I mentioned, the rendering will escape the link and it should work as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning that, I just a few minutes ago fixed a problem with a link with two dashes that I had to escape as well, for rendering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it didn't work in the end, the comment doesn't appear -_-