Issue017981 #1
Open
Issue017981 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show in images @todo, look how to deal with other units
| <div class="content-view-embed"> | ||
| <div class="class-image"> | ||
| <div class="attribute-image">{if is_set( $link_parameters.href )}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size href=$link_parameters.href|ezurl target=$link_parameters.target link_class=first_set( $link_parameters.class, '' ) link_id=first_set( $link_parameters['xhtml:id'], '' ) link_title=first_set( $link_parameters['xhtml:title'], '' ) border_size=first_set( $object_parameters.border_size, '0' ) border_color=first_set( $object_parameters.border_color, '' ) border_style=first_set( $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{else}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size border_size=first_set( $object_parameters.border_size, '0' ) border_color=first_set( $object_parameters.border_color, '' ) border_style=first_set( $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{/if}</div> | ||
| <div class="attribute-image">{if is_set( $link_parameters.href )}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size href=$link_parameters.href|ezurl target=$link_parameters.target link_class=first_set( $link_parameters.class, '' ) link_id=first_set( $link_parameters['xhtml:id'], '' ) link_title=first_set( $link_parameters['xhtml:title'], '' ) border_size=first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' ) border_color=first_set( $border_values_array[2], $object_parameters.border_color, '' ) border_style=first_set( $border_values_array[1], $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{else}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size border_size=first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' ) border_color=first_set( $border_values_array[2], $object_parameters.border_color, '' ) border_style=first_set( $border_values_array[1], $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{/if}</div> |
There was a problem hiding this comment.
The two occurrences of:
first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' )
Should probably be:
first_set( $border_values_array[0], $object_parameters.border_size, '0' )|int
Other then that if possible it would be great to split this line over at least 2-4 lines using {* *} between the tags to avoid whitespace.
nfrp
pushed a commit
that referenced
this pull request
Nov 8, 2011
Update package ezwebin Dutch translation--still missing: object states, c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Here's one more for your review.
issue is commented here http://issues.ez.no/IssueView.php?Id=17981&
hope it helps.