Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue017981 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue017981 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...s/ezwebin_extension/ezextension/ezwebin/design/ezwebin/override/templates/embed/image.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{if is_set( $object_parameters.border )}
{def $border_values_array = $object_parameters.border|explode( ' ' )}
{/if}
<div class="content-view-embed">
<div class="class-image">
<div class="attribute-image">{if is_set( $link_parameters.href )}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size href=$link_parameters.href|ezurl target=$link_parameters.target link_class=first_set( $link_parameters.class, '' ) link_id=first_set( $link_parameters['xhtml:id'], '' ) link_title=first_set( $link_parameters['xhtml:title'], '' ) border_size=first_set( $object_parameters.border_size, '0' ) border_color=first_set( $object_parameters.border_color, '' ) border_style=first_set( $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{else}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size border_size=first_set( $object_parameters.border_size, '0' ) border_color=first_set( $object_parameters.border_color, '' ) border_style=first_set( $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{/if}</div>
<div class="attribute-image">{if is_set( $link_parameters.href )}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size href=$link_parameters.href|ezurl target=$link_parameters.target link_class=first_set( $link_parameters.class, '' ) link_id=first_set( $link_parameters['xhtml:id'], '' ) link_title=first_set( $link_parameters['xhtml:title'], '' ) border_size=first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' ) border_color=first_set( $border_values_array[2], $object_parameters.border_color, '' ) border_style=first_set( $border_values_array[1], $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{else}{attribute_view_gui attribute=$object.data_map.image image_class=$object_parameters.size border_size=first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' ) border_color=first_set( $border_values_array[2], $object_parameters.border_color, '' ) border_style=first_set( $border_values_array[1], $object_parameters.border_style, 'solid' ) margin_size=first_set( $object_parameters.margin_size, '' )}{/if}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two occurrences of:
first_set( $border_values_array[0]|int, $object_parameters.border_size, '0' )
Should probably be:
first_set( $border_values_array[0], $object_parameters.border_size, '0' )|int

Other then that if possible it would be great to split this line over at least 2-4 lines using {* *} between the tags to avoid whitespace.


{if $object.data_map.caption.has_content}
{if is_set( $object.data_map.image.content[$object_parameters.size].width )}
Expand Down