Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Crowdin + MT issue #9620

Merged
merged 2 commits into from
Dec 8, 2023
Merged

docs: Crowdin + MT issue #9620

merged 2 commits into from
Dec 8, 2023

Conversation

domeav
Copy link
Contributor

@domeav domeav commented Dec 8, 2023

Warning about a recent change in the Crowdin tag handling that will break docusaurus <-> Crowdin <-> MT workflow.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I've been bitten by a change in the Crowdin+MT behavior and I want to make sure other Docusaurus users know about it.

Test Plan

100% doc change

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#4052 (comment)

@domeav domeav requested a review from slorber as a code owner December 8, 2023 10:51
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 71 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 89 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 74 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report

@domeav domeav marked this pull request as draft December 8, 2023 11:17
…reak docusaurus <-> Crowdin <-> MT workflow.
@domeav domeav marked this pull request as ready for review December 8, 2023 11:29
Copy link

netlify bot commented Dec 8, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f41e420
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/657360ae08946200084dad68
😎 Deploy Preview https://deploy-preview-9620--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 8, 2023
@slorber slorber changed the title #4052 Crowdin + MT issue docs: Crowdin + MT issue Dec 8, 2023
@slorber
Copy link
Collaborator

slorber commented Dec 8, 2023

Thanks 👍

@domeav
Copy link
Contributor Author

domeav commented Dec 8, 2023

Hmmm, not sure if I can do something with the lint issues (one complains it does not understand the French words I've added in my example, and I can't reproduce why the other is failing). If anyone has a clue, let me know!

@Josh-Cena
Copy link
Collaborator

@domeav If you want to fix them yourself, you can edit project-words.txt and add these words in alphabetical order.

@slorber slorber merged commit 61116e2 into facebook:main Dec 8, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants