Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and proper logging for pareto and clustering #1180

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

dhavalpatel624624
Copy link
Contributor

As titled... tested using tutorial.ipynb and still failing at the negative values as expected from robynpy_release

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@dhavalpatel624624 dhavalpatel624624 requested review from sumane81, alxlyj and sumalreddy17 and removed request for sumane81 and alxlyj December 6, 2024 18:33
Copy link
Contributor

@alxlyj alxlyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - nit: we probably want to change the call or the name to RobynLogger, but I think we should table this to the next batch of changes.

@dhavalpatel624624 dhavalpatel624624 merged commit 0b98a2f into robynpy_release Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants