Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add article for notes feature #59

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

coder-with-a-bushido
Copy link

Adds help center article for "Add to Notes" feature.

Closes https://github.com/famedly/product-management/issues/1600

Copy link
Contributor

@mErrenst mErrenst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you apply the changes I asked for first and then I'll review the German version again.
Seems like the German version is pretty accurate, I guess you used DeepL or another good tool for translation?

docs/help-center/using-famedly/notes.mdx Outdated Show resolved Hide resolved
docs/help-center/using-famedly/notes.mdx Outdated Show resolved Hide resolved
docs/help-center/using-famedly/notes.mdx Outdated Show resolved Hide resolved
docs/help-center/using-famedly/notes.mdx Outdated Show resolved Hide resolved
docs/help-center/using-famedly/notes.mdx Outdated Show resolved Hide resolved
@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/notes-feature branch 2 times, most recently from c766339 to e4ed4ee Compare November 29, 2023 15:02
@coder-with-a-bushido
Copy link
Author

Made all the changes and made the commit history clean. Could you check once @mErrenst ?

Copy link
Contributor

@mErrenst mErrenst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanwaveren Could you recheck this, too and approve? I think when the TabItem value is changed, this is fine now.

Copy link
Contributor

@rvanwaveren rvanwaveren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mErrenst Ich habe ein paar Feedbacks geschrieben. Ich würde das Ding vor allem Keine Unterhaltung/Chat nennen, weil das zwischen den Zeilen auf zwei oder mehr Personen hindeutet. Ich würde es einfach die Notizen nennen.

@td-famedly td-famedly force-pushed the karthi/notes-feature branch from 192b035 to 8a0ea57 Compare December 6, 2023 14:03
Copy link

@maren-r maren-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a few more changes

@td-famedly td-famedly force-pushed the karthi/notes-feature branch from 7448027 to 6ab2971 Compare December 7, 2023 12:12
@td-famedly td-famedly dismissed rvanwaveren’s stale review December 7, 2023 12:13

received Maren's approval

@td-famedly td-famedly merged commit ff5c479 into main Dec 7, 2023
4 checks passed
@td-famedly td-famedly deleted the karthi/notes-feature branch December 7, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants