Support cli args in the adapter #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
reviewed
Jun 28, 2024
jameysharp
approved these changes
Jun 28, 2024
elliottt
added a commit
that referenced
this pull request
Jun 28, 2024
After #394 there were some unused functions in the adapter that didn't fail in CI as we don't currently build the adapter in CI. This PR removes the unused code, and also builds the adapter in CI.
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
Integrate the adapter allocator changes from bytecodealliance/wasmtime#8594, which simplifies supporting cli args. Additionally, enable the cli args test for components, as it's now passing.
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
After fastly#394 there were some unused functions in the adapter that didn't fail in CI as we don't currently build the adapter in CI. This PR removes the unused code, and also builds the adapter in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the adapter allocator changes from bytecodealliance/wasmtime#8594, which simplifies supporting cli args.
Additionally, enable the cli args test for components, as it's now passing.