mcap recover: print status message to stderr instead of stdout #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing CI in #1290 |
james-rms
approved these changes
Dec 12, 2024
…cover-produces-invalid-file
jtbandes
deleted the
jacob/fg-9791-mcap-recover-produces-invalid-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed a bug in
mcap recoverwhich would produce an invalid file when redirecting stdout to a file.Docs
None
Description
Status message now goes to stderr instead of stdout.
Also fixed another nearby line which looked wrong, it was using Fprintln with
%wbut Fprintln doesn't accept format strings. https://pkg.go.dev/fmt#Fprintln