Make ROS1 service type retrieval more robust #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jurevreca12 confirmed that this patch fixes the issue, see #306 (comment) |
achim-k
deleted the
achim/fg-7877-assertion-error-on-read_callback_-in-roscpp-for-ros1-bridge
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix node crashing in some cases when retrieving ROS1 service types
Docs
None
Description
In #306, it was reported that foxglove bridge crashed due to this assertion when retrieving ROS1 service types. I believe that the reason for this assertion was that the header callback was set twice: Once in our code and once in the ServiceServerLink. To avoid this, I have reworked the service retrieval to not create a
ServiceServerLinkinstance but instead work with a rawros::Connection.Fixes #306