Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(math/curves): implement abstract Curve class and multiple different curve types. #4
feat(math/curves): implement abstract Curve class and multiple different curve types. #4
Changes from 2 commits
efcb985
feed830
d23b088
a1c367f
0e5a435
9358948
a5f77d8
0528588
16883ce
046996f
20168b9
a3b569d
8eb2556
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 23 in src/main/java/net/frc5183/librobot/math/curve/ExponentialCurve.java
GitHub Actions / pmd
This statement should have braces
Check warning on line 26 in src/main/java/net/frc5183/librobot/math/curve/ExponentialCurve.java
GitHub Actions / pmd
Useless parentheses.
Check warning on line 26 in src/main/java/net/frc5183/librobot/math/curve/ExponentialCurve.java
GitHub Actions / pmd
Useless parentheses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation in setter methods.
The getter and setter methods are well-implemented and documented. However, the setter methods lack input validation, which could lead to inconsistent state.
Consider adding validation in the setter methods:
These changes ensure that the curve is not set to null and that the min and max values remain consistent when changed individually.
📝 Committable suggestion