Introduced user configurable memory specification to qsub #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist of Confirmed Compatible filesgacode/shared/binAZURE-COMET
DAINT_PGI-HPC_ITER
IRIS-OMEGA
PPPL-STAMPEDE
SUMMIT-MARCONI
gacode/shared/bingacode_getversion-update_gacode.csh
|
wdeshazer
changed the title
smithsp
reviewed
Feb 6, 2024
| elif [[ $USERMPN == false ]]; then | ||
| MEMPERNODE= | ||
| fi | ||
| export MEMP |
There was a problem hiding this comment.
It looks like this is incomplete. Maybe
export MEMPERNODE
export MEMPERCPU
?
There was a problem hiding this comment.
@smithsp I'm reopening the PR and will correct. I am actually refactoring so that defaults will be set in platform qsub configurations.
|
@jmcclena wants to ensure that we are not disrupting the running behavior for other institutions. |
|
@jcandy I should have marked this as WIP. I apologize. I already found a typo and I need to run the regression tests. And also, I did want to get a sense from you on whether I should enable this for everyone. I can start a new branch to fix this one or if we can revert and I will keep working this one. @smithsp suggestions? |
9 tasks
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced User Configurable Memory Specification to
gacode/shared/bin/gacode_qsubgacode/platform/qsubProvisioned for
-memand-mem-per-cpuApplied Precedence rules
-mem=16GBCommunicates select through environment variables
Site Supplemental file responds correspondingly
gacode/shared/bin/gacode_qsubgacode/platform/qsub/qsub.PPPLgacode/platform/qsub/qsub.OMEGAgacode/shared/bin/gacode_qsub_multineeds same medicinegacode/shared/binto ensure compatibilitygacode/platform/qsubto ensure compatibilityI have taken a cursory look at all files and don't see anything glaring, but it deserves more consideration