vulkan: implement several ops relevant for ggml_opt #11769
+556
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
0cc4m
reviewed
Feb 10, 2025
| count += uint(data_a[idx] == data_b[idx]); | ||
| } | ||
|
|
||
| atomicAdd(data_d[0], D_TYPE(count)); |
There was a problem hiding this comment.
This shader crashes my Intel A770. I assume it's this atomicAdd. Maybe there is a way to avoid it?
There was a problem hiding this comment.
I'm not sure how to perform reduction with multiple workgroups without adding an extra buffer.
Maybe doing a single atomic per warp helps with your crash?
Does it also crash with this variant : a1633e4 ?
There was a problem hiding this comment.
It's surprising this crashes because int32 atomics in compute shaders are required in vulkan 1.0. Does it crash during the compile or while executing? Maybe the compiler would handle uint better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several GGML opcodes which are possibly relevant for #10544 (SUM, ARGMAX, SUB, COUNT_EQUAL, OPT_STEP_ADAMW, REPEAT_BACK).
After these patches, it is possible to run
test-optusing the Vulkan backend (with a few failures maybe caused by rounding issues?).Several issues were identified in test-backend-ops:
-b CPU)Several issues were identified in Vulkan CHECK_RESULTS mode: