Beds 3208/dashboard notifications add group subs #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…08/dashboard_notifications_add_group_subs
…08/dashboard_notifications_add_group_subs
…ls for dashboard based notifications
Deploying beaconchain with
|
| Latest commit: |
7de9ba1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8b7e049.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-3208-dashboard-notifica.beaconchain.pages.dev |
remoterami
requested changes
Oct 10, 2024
backend/pkg/commons/db/migrations/postgres/20241001065611_dashboard_notifications.sql
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| log.Infof("lock obtained") | ||
| err = dispatchNotifications() |
There was a problem hiding this comment.
Could pass ctx down and apply it to all the db queries to handle timeouts
There was a problem hiding this comment.
that won't work as those tx touch a different db. the timeout is here so that the lock eventually gets released. but as the sender has become network specific I believe the lock is also no longer needed or should be applied on network db level in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements backend handling for dashboard based notifications. Preserves handling of legacy webhook notifications to provide backward compatibility.