Remove .NET 6.0 and add .NET 9.0 #423
Conversation
Reviewer's Guide by SourceryThis pull request removes .NET 6.0 and adds .NET 9.0. The changes were made in the Directory.Build.props file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
gstraccini
bot
added
the
☑️ auto-merge
WalkthroughThis pull request focuses on updating the project's .NET version support and build configurations. The changes involve upgrading to .NET 9.0.x across multiple workflow files, removing an auto-documentation workflow, and updating the version numbering in the AppVeyor configuration. The modifications aim to modernize the project's infrastructure, remove unnecessary workflows, and align the build and deployment processes with the latest .NET version. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gstraccini[bot]](https://avatars.githubusercontent.com/in/480132?s=60&v=4){kind=small}
github-actions
bot
added
the
size/XS
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @guibranco - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR appears to be empty with no actual code changes shown in the diff. Please include the changes you intend to make.
- Migration to .NET 9.0 is premature as it hasn't been released yet. Please target a released version of .NET or wait until .NET 9.0 is officially available.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
|
@gstraccini appveyor build reset |
github-actions
bot
added
size/S
|
I'm sorry @guibranco, I can't do that. Invalid parameter. 🥺 |
|
@gstraccini help |
|
That's what I can do
Multiple commands can be issued simultaneously. Just respect each command pattern (with bot name prefix + command). Note If you aren't allowed to use this bot, a reaction with a thumbs down will be added to your comment. Tip You can tick (✅) one item from the above list, and it will be triggered! (In beta) (Only parameterless commands). |
:
|
@gstraccini appveyor reset |
|
AppVeyor next build number updated to 0! 🚀 |
github-actions
bot
added
size/M
|
Infisical secrets check: ✅ No secrets leaked! 💻 Scan logs2:30AM INF scanning for exposed secrets...
2:30AM INF 364 commits scanned.
2:30AM INF scan completed in 307ms
2:30AM INF no leaks found
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/deep-source.yml(1 hunks).github/workflows/snorkell-auto-documentation.yml(0 hunks).github/workflows/sonarcloud.yml(1 hunks)Directory.Build.props(1 hunks)appveyor.yml(2 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/snorkell-auto-documentation.yml
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/sonarcloud.yml
[error] 57-57: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pixeebot[bot]
- GitHub Check: pixeebot[bot]
- GitHub Check: Codacy Security Scan
🔇 Additional comments (4)
Directory.Build.props (1)
3-4: Consider adding .NET 9.0 test coverage.While the package targets .NET 9.0, tests are only running on .NET 8.0. Consider adding .NET 9.0 to
DotNetVersionTeststo ensure compatibility..github/workflows/deep-source.yml (1)
25-25:⚠️ Potential issueUpdate coverage report path to match test framework version.
The coverage report path in the last command still references
net8.0:This should be updated if tests will run on a different framework version.
appveyor.yml (2)
1-1: Version bump to 3.0 aligns with breaking change.The major version increment appropriately reflects the removal of .NET 6.0 support.
117-118:⚠️ Potential issueUpdate VERSIONS array to match target frameworks.
The
VERSIONSarray still includesnet6.0but notnet9.0. Update it to match the frameworks in Directory.Build.props:- $VERSIONS = ("netstandard2.0", "netstandard2.1", "net6.0", "net8.0") + $VERSIONS = ("netstandard2.0", "netstandard2.1", "net8.0", "net9.0")Likely invalid or redundant comment.
| @@ -1,6 +1,6 @@ | |||
| <Project> | |||
| <PropertyGroup Label="SDK Versions"> | |||
| <DotNetVersions>netstandard2.0;netstandard2.1;net6.0;net8.0</DotNetVersions> | |||
| <DotNetVersions>netstandard2.0;netstandard2.1;net8.0;net9.0</DotNetVersions> | |||
There was a problem hiding this comment.
💡 Codebase verification
Breaking change confirmed: .NET 6.0 support removal
Found evidence of previous .NET 6.0 support in appveyor.yml. However, the impact appears minimal:
- No framework-specific code found in the codebase
- Dependencies are already targeting newer versions
- .NET 6.0 is approaching end of support
Recommendation: Document this change in release notes as a breaking change, but it doesn't require special handling beyond that.
🔗 Analysis chain
Verify breaking changes from removing .NET 6.0 support.
The removal of net6.0 target framework might break compatibility for consumers still using .NET 6.0. Consider:
- Adding a breaking change notice in the release notes
- Communicating this change to package consumers
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for .NET 6.0 usage in the codebase
rg -l "net6\.0" --type-add "props:*.props" --type-add "csproj:*.csproj" --type props --type csproj
Length of output: 100
Script:
#!/bin/bash
# Check git history for net6.0 removal
git diff HEAD~1 Directory.Build.props
# Look for version-specific code and conditionals
rg "#if\s+NET6" -A 2
ast-grep --pattern 'if (RuntimeInformation.FrameworkDescription.StartsWith("$_"))'
Length of output: 147
Script:
#!/bin/bash
# Check for framework-specific directories and files
fd "net6.0"
# Look for framework version checks in different formats
rg -i "net6" -g "!*.props"
# Check package references with framework constraints
fd -e csproj -x cat {} \; | rg -i "packagereference|targetframework"
Length of output: 1936
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '9.0.x' | ||
|
|
There was a problem hiding this comment.
Update coverage paths in SonarCloud configuration.
The SonarCloud configuration still references net8.0 in coverage paths:
/d:sonar.cs.opencover.reportsPaths="Tests/**/coverage.net8.0.opencover.xml"This should be updated if tests will run on a different framework version.
Also, remove the trailing whitespace on line 57.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 57-57: trailing spaces
(trailing-spaces)
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
|
|
✅ Build VTEX-SDK-dotnet 3.0.8 completed (commit 3a8ba3def2 by @gstraccini[bot]) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=====================================
Coverage 0.22% 0.22%
=====================================
Files 117 117
Lines 1777 1777
Branches 75 75
=====================================
Hits 4 4
+ Misses 1773 1771 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
📑 Description
Remove .NET 6.0 and add .NET 9.0
✅ Checks
☢️ Does this introduce a breaking change?
Summary by Sourcery
Build:
Description by Korbit AI
What change is being made?
Remove support for .NET 6.0 and add support for .NET 9.0 across the project configuration files, as well as update build metadata in
appveyor.yml.Why are these changes being made?
These changes update the codebase to support the latest .NET 9.0 version, ensuring compatibility with the newest features and improvements. This reflects a shift towards using a more current .NET release, which will enhance performance and security, while also addressing the needs for maintenance of deprecated versions. The modifications in
appveyor.ymlalso correct a format issue with build version artifact naming.Summary by CodeRabbit
Release Notes
Infrastructure Updates
Build Configuration
Maintenance