Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .NET 6.0 and add .NET 9.0 #423

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Remove .NET 6.0 and add .NET 9.0 #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bdabd98
Update Directory.Build.props
guibranco Jan 13, 2025
74dbb05
Update appveyor.yml
guibranco Jan 13, 2025
02442ea
Delete .github/workflows/snorkell-auto-documentation.yml
guibranco Jan 13, 2025
5deaeb4
Update appveyor.yml
guibranco Jan 13, 2025
bb47d86
Update deep-source.yml
guibranco Jan 13, 2025
c7a783a
Update sonarcloud.yml
guibranco Jan 13, 2025
9deb86c
Merge branch 'main' into guibranco-patch-2
gstraccini[bot] Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deep-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.0.x'
dotnet-version: '9.0.x'

- name: Build and analyze
env:
Expand Down
19 changes: 0 additions & 19 deletions .github/workflows/snorkell-auto-documentation.yml
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ jobs:
echo "KEY=${KEY}" >> "${GITHUB_ENV}" # Keep the variable KEY as it
echo "ORG=${ORG@L}" >> "${GITHUB_ENV}" # Lowercase the ORG variable

- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: '9.0.x'

Comment on lines +53 to +57
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update coverage paths in SonarCloud configuration.

The SonarCloud configuration still references net8.0 in coverage paths:

/d:sonar.cs.opencover.reportsPaths="Tests/**/coverage.net8.0.opencover.xml"

This should be updated if tests will run on a different framework version.

Also, remove the trailing whitespace on line 57.

🧰 Tools
🪛 yamllint (1.35.1)

[error] 57-57: trailing spaces

(trailing-spaces)

- name: Build and analyze
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup Label="SDK Versions">
<DotNetVersions>netstandard2.0;netstandard2.1;net6.0;net8.0</DotNetVersions>
<DotNetVersions>netstandard2.0;netstandard2.1;net8.0;net9.0</DotNetVersions>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Breaking change confirmed: .NET 6.0 support removal

Found evidence of previous .NET 6.0 support in appveyor.yml. However, the impact appears minimal:

  • No framework-specific code found in the codebase
  • Dependencies are already targeting newer versions
  • .NET 6.0 is approaching end of support

Recommendation: Document this change in release notes as a breaking change, but it doesn't require special handling beyond that.

🔗 Analysis chain

Verify breaking changes from removing .NET 6.0 support.

The removal of net6.0 target framework might break compatibility for consumers still using .NET 6.0. Consider:

  1. Adding a breaking change notice in the release notes
  2. Communicating this change to package consumers
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for .NET 6.0 usage in the codebase
rg -l "net6\.0" --type-add "props:*.props" --type-add "csproj:*.csproj" --type props --type csproj

Length of output: 100

Script:

#!/bin/bash
# Check git history for net6.0 removal
git diff HEAD~1 Directory.Build.props

# Look for version-specific code and conditionals
rg "#if\s+NET6" -A 2
ast-grep --pattern 'if (RuntimeInformation.FrameworkDescription.StartsWith("$_"))'

Length of output: 147

Script:

#!/bin/bash
# Check for framework-specific directories and files
fd "net6.0"

# Look for framework version checks in different formats
rg -i "net6" -g "!*.props"

# Check package references with framework constraints
fd -e csproj -x cat {} \; | rg -i "packagereference|targetframework"

Length of output: 1936

<DotNetVersionTests>net8.0</DotNetVersionTests>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 2.4.{build}
version: 3.0.{build}
skip_tags: true
image: Visual Studio 2022
configuration: Release
Expand Down Expand Up @@ -114,8 +114,8 @@ after_build:
- ps: |
foreach($version in $VERSIONS)
{
7z a -tzip -mx9 "$env:SOLUTION_NAME.Core.$version.$env:APPVEYOR_BUILD_VERSION:.zip" Build\Core\$version\
Push-AppveyorArtifact "$env:SOLUTION_NAME.Core.$version.$env:APPVEYOR_BUILD_VERSION:.zip"
7z a -tzip -mx9 "$env:SOLUTION_NAME.Core.$version.$env:APPVEYOR_BUILD_VERSION.zip" Build\Core\$version\
Push-AppveyorArtifact "$env:SOLUTION_NAME.Core.$version.$env:APPVEYOR_BUILD_VERSION.zip"
foreach($project in $PROJECTS)
{
7z a -tzip -mx9 "$env:SOLUTION_NAME.$project.$version.$env:APPVEYOR_BUILD_VERSION.zip" Build\$project\$version\
Expand Down
Loading