Update monitoring and logging addon with template generation

[w13915984028]

Problem:

harvester/harvester#6289

Solution:

1. Update template generation
2. Check image tag

Related Issue:
harvester/harvester#6289

Test plan:

Peer PR: harvester/addons#14 those 2 PRs can be merged independently.

These additional ENVs will be appended to the version_info file when building, no matter addon side PR harvester/addons#14 is merged or not.

RANCHER_LOGGING_CHART_VERSION="103.1.0+up4.4.0"
RANCHER_MONITORING_CHART_VERSION="103.1.1+up45.31.1"
HARVESTER_EVENTROUTER_FULL_TAG="rancher/harvester-eventrouter:v0.3.1"

build output:

logging chart version is updated to 103.1.0+up4.4.0
monitoring chart version is updated to 103.1.1+up45.31.1
harvester-eventrouter image tag is updated to rancher/harvester-eventrouter:v0.3.1
#!/bin/bash
VM_IMPORT_CONTROLLER_CHART_VERSION="0.4.0"
VM_IMPORT_CONTROLLER_IMAGE="rancher/harvester-vm-import-controller:v0.4.0"
PCIDEVICES_CONTROLLER_CHART_VERSION="0.4.0"
PCIDEVICES_CONTROLLER_IMAGE="rancher/harvester-pcidevices:v0.4.0"
HARVESTER_SEEDER_CHART_VERSION="0.3.0"
HARVESTER_SEEDER_IMAGE="rancher/harvester-seeder:v0.3.0"
NVIDIA_DRIVER_RUNTIME_CHART_VERSION="0.1.1"
RANCHER_LOGGING_CHART_VERSION="103.1.0+up4.4.0"
RANCHER_MONITORING_CHART_VERSION="103.1.1+up45.31.1"
HARVESTER_EVENTROUTER_FULL_TAG="rancher/harvester-eventrouter:v0.3.1"
the rendered addon template
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "0.4.0"
      chart: harvester-vm-import-controller
--
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "0.4.0"
      chart: harvester-pcidevices-controller
--
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "103.1.0+up4.4.0"
      chart: rancher-logging
--
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "103.1.1+up45.31.1"
      chart: rancher-monitoring
--
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "0.3.0"
      chart: harvester-seeder
--
      repo: http://harvester-cluster-repo.cattle-system.svc/charts
      version: "0.1.1"
      chart: nvidia-driver-runtime

[tserong]

I found a couple of little nits (see below). The main thing I'm wondering though is, it appears that LOGGING_VERSION, MONITORING_VERSION and HARVESTER_EVENTROUTER_FULL_TAG defined in harvester-installer will always override whatever values are set in the addons repo. Would it not be better to instead have harvester-installer take those values from addons version_info, treating that file as the single source of truth, and remove scripts/version-logging and scripts-version-monitoring from harvester-installer?

[w13915984028]

@tserong A good question, why not use addon as a single source:

There are some patches on path https://github.com/harvester/harvester-installer/tree/master/pkg/config/templates/patch, which are related to monitoring and logging. And the monitoring and logging ENVs are also used in some other files.

package-harvester-os:source ${SCRIPTS_DIR}/version-monitoring
build:source ${SCRIPTS_DIR}/version-monitoring

I will spend another time to finally move them all to a single place if possible. thanks.

[tserong]

Thanks @w13915984028 !

[bk201]

lgtm, just a minor nit.

[tserong]

@Mergifyio backport v1.4

[mergify]

backport v1.4

✅ Backports have been created

• #816 Update monitoring and logging addon with template generation (backport #792) has been created for branch v1.4 but encountered conflicts