Fix VM related test cases

[torchiaf]

Related issue #1196

The VM tests are failing because the node harvester-node-0 has a test-custom-name customName in Harvester configuration; This breaks the cypress tests in matching the correct UI elements.

• I've updated the tests to support host's customName.
• I added the customName in host config. This will require to update the config in Jenkins pipelines:
  • host should be always an array
  • if customName is empty, the name will be used during the tests

  "host": [
    {
      "name": "",
      "customName": "",
      "disks": [
        {
          "name": "",
          "devPath": ""
        }
      ],
      "witnessNode": false
    }
  ],

[a110605]

filterWitnessNode() and witnessNode config feild are not used in the code.
Are they prepare for future test cases use?

[torchiaf]

Yes, I would keep this code for future test cases.

[a110605]

Even host is prefilled with a item in cypress.env.json.
How about add an early return error message if hostList is empty or undefined ?
Same in node-scheduling.spec.ts.

[torchiaf]

Good idea, I just added a hosts util to do that.

[a110605]

Code change LTGM.
Could you verify test cases pass on jenkins pipeline env again before merge PR?

[TachunLin]

Tested on the main Jenkins for this test changes along with the harvester-baremetal-ansible pull request

• Added the corresponding witness mode setting in cypress.config.ts.j2 and cypress.env.json.j2
  https://github.com/TachunLin/harvester-baremetal-ansible/tree/fix-cypress-test-1319

According to the latest test result on the staging Jenkins of:

• Jobs: http://172.19.98.192:8080/job/harvester-cypress-test/8/console
• Test report: https://minio.provo.rancherlabs.com:31524/cypress-test-report/cypress/results/20240617-101755-512c1bd/index.html

It will encounter the Cannot read properties of undefined (reading split) failure, just as what we encounter last week.

Checked the package.json, the adm-zip version seems not changed, it looks like it should be rebase to sync with the latest main.
https://github.com/torchiaf/harvester-tests/blob/cypress-1196/cypress/package.json

[torchiaf]

Thanks @TachunLin . Yes, this needs a rebase.

[torchiaf]

I just rebased the PR with upstream main branch. The Cannot read properties of undefined (reading split) error should be fixed now.

[TachunLin]

Thanks for the rebase with main.

• Tested again on the staging Jenkins with a Full cypress test.
  http://172.19.98.192:8080/job/harvester-cypress-test/10/console

• The Cannot read properties of undefined (reading split) have been diminished

• Check the test report, we can find the "Stop VM Negative" and "VM scheduling on Sepecific node" both failed.
  

• It looks like the test script still trying to locate the harvester-node-0 node in these scenarios
  

• Check the online Harvester environment, the node name have been changed to test-custom-name which cause the failure
  

In order to test this pull request fix, I added the following content to the harvester-baremetal-ansible repo.

• ansible/roles/cypress_tests/templates/cypress.config.ts.j2

      host: {
        name: '',
        customName: '',
        disks: [
          {
            name: '',
            devPath: '',
          },
        ],
        witnessNode: false
  

• ansible/roles/cypress_tests/templates/cypress.env.json.j2

    "host": [
    {% for node_index in range(3) %}
      {
        "name": "harvester-node-{{ node_index }}",
        "customName": "",
        "disks": [
          {
            "name": "/dev/vda",
            "devPath": "/dev/vda"
          }
        ],
        "witnessNode": false
      }{% if not loop.last %},{% endif %}
    {% endfor %}
    ],
  

@torchiaf ,
Could you help to check whether my changes to the harvester-baremetal-anisble Jenkins config can meet the requirement and correct. Or if I miss out anything. Thank you.

[torchiaf]

@TachunLin In this scenario, the result of ansible/roles/cypress_tests/templates/cypress.env.json.j2 template, should be:

"customName": "test-custom-name",

  "host": [
    {
      "name": "harvester-node-0",
      "customName": "test-custom-name",
      "disks": [
        {
          "name": "/dev/vda",
          "devPath": "/dev/vda"
        }
      ],
      "witnessNode": false
    },
    ...
  ],

I would change the template in something like this, or declare a variable for the host-0 -> custom name and use it wherever needed:

  "host": [
  {% for node_index in range(3) %}
    {
      "name": "harvester-node-{{ node_index }}",
      "customName": "{% if node_index == 0 %}test-custom-name{% else %}{% endif %}",
      "disks": [
        {
          "name": "/dev/vda",
          "devPath": "/dev/vda"
        }
      ],
      "witnessNode": false
    }{% if not loop.last %},{% endif %}
  {% endfor %}
  ],

[TachunLin]

Thanks @torchiaf for your suggestion, I updated the harvester-baremetal-ansible commit pull request.
https://github.com/harvester/harvester-baremetal-ansible/pull/58

And trigger a new full cypress test on the staging Jenkins
http://172.19.98.192:8080/job/harvester-cypress-test/11/console

On the cypress test report:
https://minio.provo.rancherlabs.com:31524/cypress-test-report/cypress/results/20240618-100419-6226eb6/index.html

We can find the Stop VM Negative and VM scheduling on Specific node cases are both SUCCESS

[TachunLin]

LGTM.
Tested can PASS the Stop VM Negative and VM scheduling on Specific node on the stating Jenkins full cypress test.
https://minio.provo.rancherlabs.com:31524/cypress-test-report/cypress/results/20240618-100419-6226eb6/index.html

Thanks for fixing the issues.